Re: [Qemu-devel] Why I advise against using ivshmem

On Wed, Jun 18, 2014 at 10:57 PM, David Marchand
[off-list ref] wrote:

On 06/18/2014 12:48 PM, Stefan Hajnoczi wrote:

quoted

One more thing to add to the list:

static void ivshmem_read(void *opaque, const uint8_t * buf, int flags)

The "flags" argument should be "size".  Size should be checked before
accessing buf.

You are welcome to send a fix and I will review it.

I don't plan to send ivshmem patches in the near future because I
don't use or support it.

I thought you were interested in bringing ivshmem up to a level where
distros feel comfortable enabling and supporting it.  Getting there
will require effort from you to audit, clean up, and achieve test
coverage.  That's what a maintainer needs to do in a case like this.

Stefan