Re: [PATCH v2] virtio: Use pci_enable_msix_exact() instead of pci_enable_msix()
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2014-02-22 21:13:32
Also in:
linux-pci, lkml
On Fri, Feb 21, 2014 at 06:01:28PM +0100, Alexander Gordeev wrote:
As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() or pci_enable_msi_exact() and pci_enable_msix_range() or pci_enable_msix_exact() interfaces.
Acked-by: Michael S. Tsirkin <mst@redhat.com>
quoted hunk ↗ jump to hunk
Signed-off-by: Alexander Gordeev <redacted> Cc: Rusty Russell <redacted> Cc: "Michael S. Tsirkin" <mst@redhat.com> Cc: virtio-dev@lists.oasis-open.org Cc: virtualization@lists.linux-foundation.org Cc: linux-pci@vger.kernel.org --- drivers/virtio/virtio_pci.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index a416f9b..101db3f 100644 --- a/drivers/virtio/virtio_pci.c +++ b/drivers/virtio/virtio_pci.c@@ -333,10 +333,8 @@ static int vp_request_msix_vectors(struct virtio_device *vdev, int nvectors, for (i = 0; i < nvectors; ++i) vp_dev->msix_entries[i].entry = i; - /* pci_enable_msix returns positive if we can't get this many. */ - err = pci_enable_msix(vp_dev->pci_dev, vp_dev->msix_entries, nvectors); - if (err > 0) - err = -ENOSPC; + err = pci_enable_msix_exact(vp_dev->pci_dev, + vp_dev->msix_entries, nvectors); if (err) goto error; vp_dev->msix_enabled = 1;-- 1.7.7.6 -- Regards, Alexander Gordeev agordeev@redhat.com