Re: [PATCH net-next v2 4/4] virtio-net: initial debugfs support, export mergeable rx buffer size
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2014-01-08 19:21:09
Also in:
netdev
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2014-01-08 19:21:09
Also in:
netdev
On Wed, Jan 08, 2014 at 02:34:31PM +0800, Jason Wang wrote:
On 01/07/2014 01:25 PM, Michael Dalton wrote:quoted
Add initial support for debugfs to virtio-net. Each virtio-net network device will have a directory under /virtio-net in debugfs. The per-network device directory will contain one sub-directory per active, enabled receive queue. If mergeable receive buffers are enabled, each receive queue directory will contain a read-only file that returns the current packet buffer size for the receive queue. Signed-off-by: Michael Dalton <redacted>This looks more complicated than expected. How about just adding an entry in sysfs onto the existed network class device which looks more simpler?
sysfs is part of userspace ABI, I think that's the main issue: can we commit to this attribute being there in the future? If yes we can use sysfs but maybe it seems reasonable to use debugfs for a while until we are more sure of this. I don't mind either way.