Re: [PATCH net-next 1/3] virtio_net: set multicast filter list to host
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2013-12-10 15:24:29
Also in:
netdev
On Mon, Dec 09, 2013 at 04:16:32PM -0800, Stephen Hemminger wrote:
The virtio_net driver never sends the multicast address list to
the host. This is because send command takes a pointer to scatter list
to send but only inserts that one entry into the outgoing scatter list.
This bug has been there since:
commit f565a7c259d71cc186753653d978c646d2354b36
Author: Alex Williamson [off-list ref]
Date: Wed Feb 4 09:02:45 2009 +0000
virtio_net: Add a MAC filter table
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>Acked-by: Michael S. Tsirkin <mst@redhat.com> Question is, can we detect a broken driver in the host somehow? If not we'll need a feature bit for hosts to actually do MC filtering.
quoted hunk
--- a/drivers/net/virtio_net.c 2013-12-09 16:12:03.897891975 -0800 +++ b/drivers/net/virtio_net.c 2013-12-09 16:12:36.353164803 -0800@@ -893,7 +893,7 @@ static bool virtnet_send_command(struct sg_init_one(&hdr, &ctrl, sizeof(ctrl)); sgs[out_num++] = &hdr; - if (out) + for (; out; out = sg_next(out)) sgs[out_num++] = out; if (in) sgs[out_num + in_num++] = in;