Re: [PATCH] VMXNET3: Add support for virtual IOMMU
From: Andy King <hidden>
Date: 2013-08-21 13:37:36
Also in:
lkml, netdev
From: Andy King <hidden>
Date: 2013-08-21 13:37:36
Also in:
lkml, netdev
Adding Greg, since this will apply to a similar patchset I sent out for VMCI. ----- Original Message -----
From: Andy King <redacted> Date: Tue, 20 Aug 2013 10:33:32 -0700quoted
We can't just do virt_to_phys() on memory that we pass to the device and expect it to work in presence of a virtual IOMMU. We need to add IOMMU mappings for such DMAs to work correctly. Fix that with pci_alloc_consistent() where possible, or pci_map_single() where the mapping is short-lived or we don't control the allocation (netdev).Please use dma_alloc_coherent() (or in fact dma_zalloc_coherent()), dma_map_single() et al., because they are preferred and in particular allow specification of GFP_* flags
Sorry about that, I'll fix that and send out a new patch. Thanks! - Andy