Re: [PATCH 1/5] Intel MIC Host Driver for X100 family.

On Thu, Aug 01, 2013 at 05:36:34PM -0700, Sudeep Dutt wrote:

On Wed, 2013-07-31 at 18:51 -0700, Greg Kroah-Hartman wrote: 

quoted

On Wed, Jul 24, 2013 at 08:31:32PM -0700, Sudeep Dutt wrote:

quoted

--- /dev/null
+++ b/drivers/misc/mic/common/mic_device.h

@@ -0,0 +1,81 @@
+/*
+ * Intel MIC Platform Software Stack (MPSS)
+ *
+ * Copyright(c) 2013 Intel Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License, version 2, as
+ * published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301
+ * USA.

Ok, it's now your task as an Intel employee to get this paragraph
stricken from the "default template" that GPL code in the kernel,
written by Intel developers, has.  It's pointless, and unless you want
to be personally responsible for tracking the address changes of the FSF
for the next 40+ years, not something I'm going to ever accept.

I know you aren't responsible for this, but I'm getting really tired of
pointing this out each-and-every-time I see a file from an Intel
developer.

So please work to fix this.

I brought up this issue today, with the team which reviews licenses for
open source projects at Intel. The recommendation from them is to
include the following wording instead of the FSF street address in the
standard template.

<snip>
You should have received a copy of the GNU General Public License along
with this program. If not, see <http://www.gnu.org/licenses/>.
<snip>

That's better, but, this is the kernel, and of course they got a copy of
the license with it, it's part of the whole body of code.  So that
paragraph is not needed either.

thanks,

greg k-h