Thread (9 messages) 9 messages, 5 authors, 2013-07-01

Re: [PATCH next] xen: Convert printks to pr_<level>

From: Ian Campbell <hidden>
Date: 2013-06-28 11:13:07
Also in: lkml, netdev, xen-devel

On Fri, 2013-06-28 at 03:21 -0700, Joe Perches wrote:
Convert printks to pr_<level> (excludes printk(KERN_DEBUG...)
to be more consistent throughout the xen subsystem.

Add pr_fmt with KBUILD_MODNAME or "xen:" KBUILD_MODNAME
Coalesce formats and add missing word spaces
Add missing newlines
Align arguments and reflow to 80 columns
Remove DRV_NAME from formats as pr_fmt adds the same content

This does change some of the prefixes of these messages
but it also does make them more consistent.

Signed-off-by: Joe Perches <joe@perches.com>
---

On Fri, 2013-06-28 at 09:02 +0100, Wei Liu wrote:
quoted
Do you also need to replace other printk occurences in xen-netback
directory, say, interface.c and xenbus.c?
Well, I don't _need_ to but if you want it
I think Wei just mean drivers/net/xen-blkback/{interface.c,xenbus.c} in
addition to the netback.c you were patching in your previous patch.
this is what I suggest.
Wow ;-)
 drivers/xen/balloon.c                       |  6 +++--
 drivers/xen/cpu_hotplug.c                   |  6 +++--
 drivers/xen/events.c                        | 23 +++++++++---------
 drivers/xen/evtchn.c                        |  6 +++--
 drivers/xen/gntalloc.c                      |  6 +++--
 drivers/xen/gntdev.c                        |  8 ++++---
 drivers/xen/grant-table.c                   | 17 +++++++-------
 drivers/xen/manage.c                        | 23 +++++++++---------
 drivers/xen/mcelog.c                        | 36 +++++++++++------------------
 drivers/xen/pcpu.c                          | 12 +++++-----
 drivers/xen/privcmd.c                       |  4 +++-
 drivers/xen/swiotlb-xen.c                   | 12 ++++++----
 drivers/xen/tmem.c                          | 10 ++++----
 drivers/xen/xen-acpi-cpuhotplug.c           |  2 ++
 drivers/xen/xen-acpi-memhotplug.c           |  2 ++
 drivers/xen/xen-acpi-pad.c                  |  2 ++
 drivers/xen/xen-acpi-processor.c            | 25 ++++++++++----------
 drivers/xen/xen-balloon.c                   |  6 +++--
 drivers/xen/xen-pciback/conf_space_header.c | 16 ++++++-------
 drivers/xen/xen-pciback/pci_stub.c          | 25 +++++++++-----------
 drivers/xen/xen-pciback/pciback_ops.c       |  9 +++++---
 drivers/xen/xen-pciback/vpci.c              | 10 ++++----
 drivers/xen/xen-pciback/xenbus.c            |  8 ++++---
 drivers/xen/xen-selfballoon.c               | 11 ++++-----
 drivers/xen/xenbus/xenbus_comms.c           | 13 ++++++-----
 drivers/xen/xenbus/xenbus_dev_backend.c     |  4 +++-
 drivers/xen/xenbus/xenbus_dev_frontend.c    |  4 +++-
 drivers/xen/xenbus/xenbus_probe.c           | 30 +++++++++++-------------
 drivers/xen/xenbus/xenbus_probe_backend.c   |  8 ++++---
 drivers/xen/xenbus/xenbus_probe_frontend.c  | 35 ++++++++++++++--------------
 drivers/xen/xenbus/xenbus_xs.c              | 22 ++++++++----------
 drivers/xen/xencomm.c                       |  2 ++
 drivers/xen/xenfs/super.c                   |  4 +++-
 include/xen/hvm.h                           |  4 ++--
 34 files changed, 215 insertions(+), 196 deletions(-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help