Thread (13 messages) 13 messages, 4 authors, 2013-03-13

Re: [PATCH V2 0/6] tcm_vhost hotplug/hotunplug support and locking/flushing fix

From: Paolo Bonzini <pbonzini@redhat.com>
Date: 2013-03-13 08:11:32
Also in: kvm

Il 12/03/2013 10:55, Michael S. Tsirkin ha scritto:
quoted
Why? Why should qemu prevent from improving the driver and the benefit
to the other user of the driver? Kvm tool is already using it since last
Aug. This adds the missing disk hotplug support to kvm tool.
Basically we shouldn't add stuff to kernel for a single user.
Before we commit to support features forever, let's take the time
to see that the interfaces satisfy the requirements of multiple users.
The userspace components of vhost-scsi do not need any new kernel API to
get this new feature.  In fact, there is no new kernel API introduced by
the hotplug/hotunplug patches.
quoted
Plus, this is not a pure "feature", it is designed in virtio-scsi spec. 
The spec doesn't say it's a mandatory feature or did I miss something?
It's not mandatory to support hotplug.  However, it is mandatory for the
device to provide an event virtqueue, even if it will never report an
event and it will do nothing with the virtqueue.  For this reason, a
compliant userspace must already have all the support for this.

Paolo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help