Thread (14 messages) 14 messages, 4 authors, 2013-02-25

Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings)

From: Rusty Russell <hidden>
Date: 2013-02-21 06:56:05
Also in: lkml, netdev

Ohad Ben-Cohen [off-list ref] writes:
Hi Sjur,

On Tue, Feb 12, 2013 at 1:49 PM,  [off-list ref] wrote:
quoted
From: Sjur Brændeland <redacted>

Add functions for creating, deleting and kicking host-side virtio rings.

The host ring is not integrated with virtiqueues and cannot be managed
through virtio-config.
Is that an inherent design/issue of vringh or just a description of
the current vringh code ?
It's by design.  The producer (virtqueue) and consumer (vringh) are two
sides of the same coin, but they do different things.

virtqueue is a slightly higher level abstraction which assumes a
virtio_device, because every user so far has had one.  vringh doesn't,
because it's also aimed to underlie vhost.c which doesn't really have
one.
This is possible of course thanks to the abstraction provided by
virtio: remoteproc only implements a set of callbacks which virtio
invokes when needed.

Do we not want to follow a similar design scheme with vringh ?
Hmm... I clearly jumped the gun, assuming consensus was already reached.
I have put these patches *back* into pending-rebases, and they will not
be merged this merge window.

Cheers,
Rusty.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help