Thread (10 messages) 10 messages, 5 authors, 2013-02-18

Re: [PATCH] virtio_console: Let unconnected rproc device receive data.

From: Sjur Brændeland <hidden>
Date: 2013-02-12 09:14:59

Hi Amit,
quoted
@@ -1763,8 +1763,11 @@ static void in_intr(struct virtqueue *vq)
quoted
quoted
     * tty is spawned) and the host sends out data to console
     * ports.  For generic serial ports, the host won't
     * (shouldn't) send data till the guest is connected.
+    * However a remote device might send data before the port is
+    * connected. So don't remove data from a rproc_serial device.
     */
-   if (!port->guest_connected)
+
+   if (!port->guest_connected && !is_rproc_serial(port->portdev-
vdev))
            discard_port_data(port);
How about setting port->guest_connected = true in the init routines
instead?  Keeps this code path cleaner.
Agree, I'll respin this patch.
Hm, Rusty has already picked this up. Do you still want me to do a respin,
or should I leave it as is?

Regards,
Sjur
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help