Re: [PATCH] virtio_console: correct error message on failure of debugfs_create_dir

On Mon, Dec 24, 2012 at 11:55:46AM +0000, Arnd Bergmann wrote:

On Friday 21 December 2012, Amit Shah wrote:

quoted

On (Thu) 20 Dec 2012 [14:11:21], Sasha Levin wrote:

quoted

debugfs_create_dir() returns NULL if it fails, there's little point in
calling PTR_ERR on it.

debugfs_create_dir() does return an error value if debugfs is not
enabled.

This check for !pdrvdata.debugfs_dir should infact use
IS_ERR_OR_NULL().  Care to submit a patch for that?

How about we fix the stub instead to return NULL when debugfs is disabled?

No, please read debugfs.h for why I decided to not do this (i.e. we try
to learn from our mistakes...)

thanks,

greg k-h