Thread (25 messages) 25 messages, 5 authors, 2012-11-27

Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

From: Andy King <hidden>
Date: 2012-11-21 21:10:29
Also in: lkml

Hi Joe,
Just some trivial notes.
Thanks for taking a look!
quoted
+		pr_warn("Failed to allocate memory for VMCI context.\n");
OOM logging messages aren't necessary as alloc failures
are already logged with a stack trace.
Noted, we'll remove all such occurrences.
Maybe just use
	struct vmci_event_msg e_msg;
	struct vmci_event_payld_ctx ev_payload;
and change the addressing or use a cast as appropriate?
It does seem inelegant, we'll take a look.
You also have some inconsistency in whether or not your
logging messages use a terminating period.  I suggest
you just delete all the periods.
	s/\.\\n"/\\n"/g
Gah, that's ugly.  We'll remove all of them as you suggest.

Thanks!
- Andy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help