Thread (2 messages) flat view 2 messages, 2 authors, 2012-11-16

Re: [PATCH 09/14] xen: events: Remove redundant check on unsigned variable

From: Konrad Rzeszutek Wilk <hidden>
Date: 2012-11-16 16:09:37
Also in: lkml, xen-devel

On Fri, Nov 16, 2012 at 12:20:41PM +0530, Tushar Behera wrote:
No need to check whether unsigned variable is less than 0.

CC: Konrad Rzeszutek Wilk <redacted>
Acked-by: Konrad Rzeszutek Wilk <redacted>
quoted hunk
CC: Jeremy Fitzhardinge <redacted>
CC: xen-devel@lists.xensource.com
CC: virtualization@lists.linux-foundation.org
Signed-off-by: Tushar Behera <redacted>
---
 drivers/xen/events.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/xen/events.c b/drivers/xen/events.c
index 4293c57..cadd7d1 100644
--- a/drivers/xen/events.c
+++ b/drivers/xen/events.c
@@ -216,7 +216,7 @@ static void xen_irq_info_pirq_init(unsigned irq,
  */
 static unsigned int evtchn_from_irq(unsigned irq)
 {
-	if (unlikely(WARN(irq < 0 || irq >= nr_irqs, "Invalid irq %d!\n", irq)))
+	if (unlikely(WARN(irq >= nr_irqs, "Invalid irq %d!\n", irq)))
 		return 0;
 
 	return info_for_irq(irq)->evtchn;
-- 
1.7.4.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help