Thread (10 messages) 10 messages, 2 authors, 2012-10-16

Re: [PATCH 1/5] virtio: move queue_index and num_free fields into core struct virtqueue.

flat view

From: Rusty Russell <hidden>
Date: 2012-10-16 14:19:34

"Michael S. Tsirkin" [off-list ref] writes:
On Wed, Oct 17, 2012 at 12:00:48AM +1030, Rusty Russell wrote:
quoted
  * @priv: a pointer for the virtqueue implementation to use.
+ * @index: the zero-based ordinal number for this queue.
+ * @num_free: number of buffers we expect to be able to fit.
Only it's not exactly buffers: a single buffer can use
multiple s/g entries, right?
Maybe clarify as 'linear buffers'?
Yes, it needs clarification, but I don't think I can do so tersely.

Here's what I ended up with:

 * @num_free: number of elements we expect to be able to fit.
 *
 * A note on @num_free: with indirect buffers, each buffer needs one
 * element in the queue, otherwise a buffer will need one element per
 * sg element.

Thanks,
Rusty.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help