Re: [PATCH] virtio-blk: Fix kconfig option
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2012-09-05 06:03:24
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2012-09-03 · Re: [PATCH] virtio-blk: Fix kconfig option · Kent Overstreet <hidden>
- 2012-09-03 · [PATCH] virtio-blk: Fix kconfig option · Kent Overstreet <hidden>
On Wed, Sep 05, 2012 at 01:54:07PM +0800, Asias He wrote:
On 09/05/2012 01:48 PM, Michael S. Tsirkin wrote:quoted
On Wed, Sep 05, 2012 at 12:22:58PM +0800, Asias He wrote:quoted
On 09/04/2012 02:23 PM, Rusty Russell wrote:quoted
Kent Overstreet [off-list ref] writes:quoted
CONFIG_VIRTIO isn't exposed, everything else is supposed to select it instead.This is a slight mis-understanding. It's supposed to be selected by the particular driver, probably virtio_pci in your case.virtio_mmio selects virtio as well. drivers/virtio/Kconfig config VIRTIO_MMIO select VIRTIO config VIRTIO_PCI select VIRTIO How about this: config VIRTIO_BLK depends on EXPERIMENTAL && (VIRTIO_PCI || VIRTIO_MMIO)Isn't this exactly what depends on VIRTIO achieves?Yes. But this gives the information that virtio_blk depends on one of the virtio transport: virito_pci or virtio_mmio.
It can work with any transport.
-- Asias