Re: [PATCH 5/5] virtio-scsi: introduce multiqueue support

From
Michael S. Tsirkin <mst@redhat.com>
Date
2012-09-04 14:46:38
Also in
kvm, linux-scsi, lkml
Reply to
Paolo Bonzini, 2012-08-28
On Tue, Aug 28, 2012 at 01:54:17PM +0200, Paolo Bonzini wrote:
quoted hunk ↗ jump to hunk
@@ -575,15 +630,19 @@ static struct scsi_host_template virtscsi_host_template = {
 				  &__val, sizeof(__val)); \
 	})
 
+
Pls don't add empty lines.
quoted hunk ↗ jump to hunk
 static void virtscsi_init_vq(struct virtio_scsi_vq *virtscsi_vq,
-			     struct virtqueue *vq)
+			     struct virtqueue *vq, bool affinity)
 {
 	spin_lock_init(&virtscsi_vq->vq_lock);
 	virtscsi_vq->vq = vq;
+	if (affinity)
+		virtqueue_set_affinity(vq, virtqueue_get_queue_index(vq) -
+				       VIRTIO_SCSI_VQ_BASE);
 }
 
This means in practice if you have less virtqueues than CPUs,
things are not going to work well, will they?

Any idea what to do?

-- 
MST
Thread (34 messages) 34 messages, 7 authors, last reply 2012-09-06
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help