Thread (8 messages) 8 messages, 4 authors, 2012-09-11

Re: [PATCH 4/5] virtio-scsi: Add start/stop functionality for vhost-scsi

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2012-09-08 22:39:24
Also in: kvm, qemu-devel

Possibly related (same subject, not in this thread)

On Fri, Sep 07, 2012 at 06:00:50PM +0200, Paolo Bonzini wrote:
Il 07/09/2012 08:48, Nicholas A. Bellinger ha scritto:
quoted
Cc: Stefan Hajnoczi <redacted>
Cc: Zhi Yong Wu <redacted>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Nicholas Bellinger <redacted>
---
 hw/virtio-pci.c  |    2 ++
 hw/virtio-scsi.c |   49 +++++++++++++++++++++++++++++++++++++++++++++++++
 hw/virtio-scsi.h |    1 +
 3 files changed, 52 insertions(+), 0 deletions(-)
Please create a completely separate device vhost-scsi-pci instead (or
virtio-scsi-tcm-pci, or something like that).  It is used completely
differently from virtio-scsi-pci, it does not make sense to conflate the
two.

Paolo
Ideally the name would say how it is different, not what backend it
uses. Any good suggestions?

-- 
MST
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help