[PATCH v3 1/2] virtio-ring: Use threshold for switching to indirect descriptors · Sasha Levin <hidden> · 2012-08-30
[PATCH v3 2/2] virtio-ring: Allocate indirect buffers from cache when possible · Sasha Levin <hidden> · 2012-08-30
Re: [PATCH v3 2/2] virtio-ring: Allocate indirect buffers from cache when possible · "Michael S. Tsirkin" <mst@redhat.com> · 2012-08-30
Re: [PATCH v3 2/2] virtio-ring: Allocate indirect buffers from cache when possible · Sasha Levin <hidden> · 2012-08-31
Re: [PATCH v3 2/2] virtio-ring: Allocate indirect buffers from cache when possible · "Michael S. Tsirkin" <mst@redhat.com> · 2012-08-31
Re: [PATCH v3 2/2] virtio-ring: Allocate indirect buffers from cache when possible · Avi Kivity <hidden> · 2012-09-04
Re: [PATCH v3 2/2] virtio-ring: Allocate indirect buffers from cache when possible · Avi Kivity <hidden> · 2012-09-04
Re: [PATCH v3 2/2] virtio-ring: Allocate indirect buffers from cache when possible · "Michael S. Tsirkin" <mst@redhat.com> · 2012-09-04
Re: [PATCH v3 2/2] virtio-ring: Allocate indirect buffers from cache when possible · Avi Kivity <hidden> · 2012-09-05
Re: [PATCH v3 2/2] virtio-ring: Allocate indirect buffers from cache when possible · "Michael S. Tsirkin" <mst@redhat.com> · 2012-09-05
Re: [PATCH v3 1/2] virtio-ring: Use threshold for switching to indirect descriptors · "Michael S. Tsirkin" <mst@redhat.com> · 2012-08-30

Re: [PATCH v3 2/2] virtio-ring: Allocate indirect buffers from cache when possible

From: Sasha Levin <hidden>
Date: 2012-08-31 09:35:39
Also in: kvm, lkml

On 08/30/2012 03:38 PM, Michael S. Tsirkin wrote:

quoted

+static unsigned int indirect_alloc_thresh = 16;

Why 16?  Please make is MAX_SG + 1 this makes some sense.

Wouldn't MAX_SG mean we always allocate from the cache? Isn't the memory waste
too big in this case?