Thread (1 message) 1 message, 1 author, 2012-08-30

Re: [PATCH 01/11] vmci_context.patch: VMCI context list operations.

From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Date: 2012-08-30 20:57:35
Also in: lkml

On Thu, Aug 30, 2012 at 09:38:08AM -0700, George Zhang wrote:
+/* VMCICptBufInfo: Used to set/get current context's checkpoint state. */
+struct vmci_ctx_chkpt_buf_info {
+       uint64_t cptBuf;
+       uint32_t cptType;
+       uint32_t bufSize;
+       int32_t result;
+       uint32_t _pad;
+};
Please use the proper kernel types when you are passing structures
across the kernel/user boundry (hint, you should NEVER be using the
uint*_t types in the kernel).  You need to fix up all of the structures
that you pass through your ioctl, to use the correct __ types, and fix
up everything else to use the other types.

Also, you have a crazy variable naming scheme everywhere, remember, you
can use vowels and '_' characters :)

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help