Re: [RFC-v2 6/6] virtio-scsi: Fix incorrect VirtIOSCSI->cmd_vqs[0] definition
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2012-08-13 09:02:10
Also in:
kvm, qemu-devel
On Mon, Aug 13, 2012 at 08:35:17AM +0000, Nicholas A. Bellinger wrote:
From: Nicholas Bellinger <redacted> This patch fixes bug in the definition of VirtIOSCSI->cmd_vqs[0], where the return of virtio_add_queue() in virtio_scsi_init() ends up overwriting past the end of ->cmd_vqs[0]. Since virtio_scsi currently assumes a single vqs for data, this patch simply changes ->cmd_vqs[1] to handle the single VirtQueue. Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Stefan Hajnoczi <redacted> Cc: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Nicholas Bellinger <redacted>
This is a bugfix we need even without vhost, right?
quoted hunk
--- hw/virtio-scsi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/hw/virtio-scsi.c b/hw/virtio-scsi.c index 5e2ff6b..2c70f89 100644 --- a/hw/virtio-scsi.c +++ b/hw/virtio-scsi.c@@ -150,7 +150,7 @@ typedef struct { bool events_dropped; VirtQueue *ctrl_vq; VirtQueue *event_vq; - VirtQueue *cmd_vqs[0]; + VirtQueue *cmd_vqs[1]; bool vhost_started; VHostSCSI *vhost_scsi;-- 1.7.2.5