Re: [PATCH 6/6] virtio-scsi: Set shost->max_id=1 for tcm_vhost WWPNs
From: Paolo Bonzini <pbonzini@redhat.com>
Date: 2012-07-04 14:50:56
Also in:
kvm, linux-scsi
Il 04/07/2012 06:24, Nicholas A. Bellinger ha scritto:
From: Nicholas Bellinger <redacted> This is currently required for connecting to tcm_vhost in order to prevent the client LUN scan from detecting the same tcm_vhost WWPN on multiple target IDs.
But that's what the config field is for... why can't tcm_vhost (or QEMU) set max_id to 0? Paolo
quoted hunk
Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Stefan Hajnoczi <redacted> Cc: Zhi Yong Wu <redacted> Cc: Christoph Hellwig <hch@lst.de> Cc: Hannes Reinecke <hare@suse.de> Signed-off-by: Nicholas Bellinger <redacted> --- drivers/scsi/virtio_scsi.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 391b30d..8711951 100644 --- a/drivers/scsi/virtio_scsi.c +++ b/drivers/scsi/virtio_scsi.c@@ -475,7 +475,10 @@ static int __devinit virtscsi_probe(struct virtio_device *vdev) shost->cmd_per_lun = min_t(u32, cmd_per_lun, shost->can_queue); shost->max_sectors = virtscsi_config_get(vdev, max_sectors) ?: 0xFFFF; shost->max_lun = virtscsi_config_get(vdev, max_lun) + 1; - shost->max_id = virtscsi_config_get(vdev, max_target) + 1; + /* + * Currently required for tcm_vhost to function.. + */ + shost->max_id = 1; shost->max_channel = 0; shost->max_cmd_len = VIRTIO_SCSI_CDB_SIZE; err = scsi_add_host(shost, &vdev->dev);