Thread (8 messages) 8 messages, 4 authors, 2012-05-31

Re: [PATCH RFC] virtio-net: remove useless disable on freeze

From: Rusty Russell <hidden>
Date: 2012-05-31 06:49:25
Also in: kvm, lkml, netdev

On Mon, 28 May 2012 15:53:25 +0300, "Michael S. Tsirkin" [off-list ref] wrote:
On Wed, Apr 04, 2012 at 12:19:54PM +0300, Michael S. Tsirkin wrote:
quoted
disable_cb is just an optimization: it
can not guarantee that there are no callbacks.

I didn't yet figure out whether a callback
in freeze will trigger a bug, but disable_cb
won't address it in any case. So let's remove
the useless calls as a first step.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Looks like this isn't in the 3.5 pull request -
just lost in the shuffle?
disable_cb is advisory so can't be relied upon.
I always (try to?) reply as I accept patches.

This one did slip by, but it's harmless so no need to push AFAICT.

Applied.

Thanks!
Rusty.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help