Thread (10 messages) 10 messages, 5 authors, 2012-04-11

Re: [PATCH] virtio_blk: Add help function to format mass of disks

From: Tejun Heo <tj@kernel.org>
Date: 2012-04-10 15:49:56
Also in: kvm, linux-scsi, lkml

Hello, guys.

On Tue, Apr 10, 2012 at 04:34:06PM +0300, Michael S. Tsirkin wrote:
quoted
Why not use 'base' below?  neither unit nor base change.
Yes it's a bit strange, it was the same in Tejun's patch.
Tejun, any idea?
It was years ago, so I don't recall much.  I think I wanted to use a
variable name which signifies its role - I worked out the rather
convoluted base number logic on paper first and I probably wanted to
keep the distinctions.  I don't think it really matters at this point
tho.  Just make sure those functions are marked deprecated so that no
one else copies them.

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help