[PATCH 1/1] Drivers: scsi: storvsc: Properly handle errors from the host
From: "K. Y. Srinivasan" <kys@microsoft.com>
Date: 2012-03-29 23:47:13
Also in:
linux-scsi, lkml
Subsystem:
hyper-v/azure core and drivers, scsi subsystem, the rest · Maintainers:
"K. Y. Srinivasan", Haiyang Zhang, Wei Liu, Dexuan Cui, Long Li, "James E.J. Bottomley", "Martin K. Petersen", Linus Torvalds
If the host returns error for pass through commands, deal with appropriately. I would like to thank James for patiently helping me with this patch. Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com> --- drivers/scsi/storvsc_drv.c | 20 ++++++++++++++++---- 1 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 83a1972..5053769 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c@@ -785,12 +785,24 @@ static void storvsc_command_completion(struct storvsc_cmd_request *cmd_request) /* * If there is an error; offline the device since all * error recovery strategies would have already been - * deployed on the host side. + * deployed on the host side. However, if the command + * were a pass-through command deal with it appropriately. */ - if (vm_srb->srb_status == SRB_STATUS_ERROR) - scmnd->result = DID_TARGET_FAILURE << 16; - else + switch (vm_srb->srb_status) { + case SRB_STATUS_ERROR: + switch (scmnd->cmnd[0]) { + case ATA_16: + case ATA_12: + scmnd->result = DID_PASSTHROUGH << 16; + break; + default: + scmnd->result = DID_TARGET_FAILURE << 16; + } + break; + default: scmnd->result = vm_srb->scsi_status; + } + /* * If the LUN is invalid; remove the device.
--
1.7.4.1