Thread (2 messages) 2 messages, 2 authors, 2012-03-20

Re: [Qemu-devel] [PATCHv2] virtio-pci: add MMIO property

From: Paul Brook <hidden>
Date: 2012-03-20 16:32:23

quoted hunk ↗ jump to hunk
@@ -682,10 +733,18 @@ void virtio_init_pci(VirtIOPCIProxy *proxy,
VirtIODevice *vdev) if (size & (size-1))
         size = 1 << qemu_fls(size);
 
+    proxy->bar0_mask = size - 1;
You'll get better performance if you use page-sized mappings.  You're already 
creating a mapping bigger than the actual data (rounding up to power-of-two), 
so you may as well pick a value that's convenient for qemu to map into the 
address space.

Paul
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help