Thread (10 messages) 10 messages, 4 authors, 2012-03-15

Re: [Xen-devel] [PATCH 0001/001] xen: multi page ring support for block devices

From: Jan Beulich <hidden>
Date: 2012-03-15 08:03:00

Possibly related (same subject, not in this thread)

quoted
quoted
On 14.03.12 at 18:01, Justin Gibbs [off-list ref] wrote:
While we're talking about fixing ring data structures, can RING_IDX
be defined as a "uint32_t" instead of "unsigned int".  The structure
padding in the ring macros assumes RING_IDX is exactly 4 bytes,
so this should be made explicit.  ILP64 machines may still be a way
out, but the use of non-fixed sized types in places where size really
matters just isn't clean.
Yes, if we're going to rev the interface, then any such flaws should be
corrected.

(Also shrinking the Cc list a little.)

Jan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help