On Thu, Feb 02, 2012 at 11:41:29PM +0000, KY Srinivasan wrote:

quoted

quoted

+#ifndef __packed
+#define __packed __attribute__((packed))
+#endif

Why do this?

If you are so worried about this in userspace, then just change the
values below to __attribute__((packed)), like all of the other public .h
files do.

Greg,

When I ran the checkpatch script against these patches I got a warning that the
preferred directive was to use "__packed".

Well, checkpatch is stupid sometimes.

So, for the header file that will be
consumed in the kernel, I chose to go with the __packed. For inclusion of this
header file in the user space daemon, I put in this definition here. So rather
than having numerous warnings, I now have a single warning. If you prefer,
I can move this definition to the daemon code where it is really needed.

Please do it like all other public kernel header files do.

greg k-h