Re: [Xen-devel] [PATCH] blkfront: don't change to closing if we're busy
From: Konrad Rzeszutek Wilk <hidden>
Date: 2012-02-16 19:48:01
Also in:
xen-devel
On Thu, Feb 16, 2012 at 01:17:09PM +0100, Andrew Jones wrote:
We just reported to xenbus that we can't close yet, because blkfront is still in use. So we shouldn't then immediately state that we are closing.
What happens if the user uses --force to unplug the device? Will that still work?
quoted hunk ↗ jump to hunk
Signed-off-by: Andrew Jones <redacted> --- drivers/block/xen-blkfront.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 5d45688..b53cae4 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c@@ -1134,7 +1134,6 @@ blkfront_closing(struct blkfront_info *info) if (bdev->bd_openers) { xenbus_dev_error(xbdev, -EBUSY, "Device in use; refusing to close"); - xenbus_switch_state(xbdev, XenbusStateClosing); } else { xlvbd_release_gendisk(info); xenbus_frontend_closed(xbdev);-- 1.7.7.5 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel