Thread (4 messages) 4 messages, 3 authors, 2012-02-21

[PATCH] blkfront: don't put bdev right after getting it

STALE5338d

From: Andrew Jones <hidden>
Date: 2012-02-16 12:16:25
Also in: xen-devel
Subsystem: block layer, the rest, xen block subsystem, xen hypervisor interface · Maintainers: Jens Axboe, Linus Torvalds, Roger Pau Monné, Juergen Gross, Stefano Stabellini

We should hang onto bdev until we're done with it.

Signed-off-by: Andrew Jones <redacted>
---
 drivers/block/xen-blkfront.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 2f22874..5d45688 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -1410,7 +1410,6 @@ static int blkif_release(struct gendisk *disk, fmode_t mode)
 	mutex_lock(&blkfront_mutex);
 
 	bdev = bdget_disk(disk, 0);
-	bdput(bdev);
 
 	if (bdev->bd_openers)
 		goto out;
@@ -1441,6 +1440,7 @@ static int blkif_release(struct gendisk *disk, fmode_t mode)
 	}
 
 out:
+	bdput(bdev);
 	mutex_unlock(&blkfront_mutex);
 	return 0;
 }
-- 
1.7.7.5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help