Re: [PATCH 1/2] virtio: fix typos of memory barriers
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2012-01-22 11:45:40
Also in:
kvm, lkml, netdev
On Fri, Jan 20, 2012 at 04:16:59PM +0800, Jason Wang wrote:
Signed-off-by: Jason Wang <jasowang@redhat.com>
Good catch. Note: this fixes a bug introduced by 7b21e34fd1c272e3a8c3846168f2f6287a4cd72b. It's probably a good idea to mention this is the commit log. Acked-by: Michael S. Tsirkin <mst@redhat.com>
quoted hunk ↗ jump to hunk
--- drivers/virtio/virtio_ring.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index 79e1b29..78428a8 100644 --- a/drivers/virtio/virtio_ring.c +++ b/drivers/virtio/virtio_ring.c@@ -35,7 +35,7 @@ #define virtio_rmb(vq) \ do { if ((vq)->weak_barriers) smp_rmb(); else rmb(); } while(0) #define virtio_wmb(vq) \ - do { if ((vq)->weak_barriers) smp_rmb(); else rmb(); } while(0) + do { if ((vq)->weak_barriers) smp_wmb(); else wmb(); } while(0) #else /* We must force memory ordering even if guest is UP since host could be * running on another CPU, but SMP barriers are defined to barrier() in that