Re: [Xen-devel] [PATCH 2/4] xen kconfig: relax INPUT_XEN_KBDDEV_FRONTEND deps

----- Original Message -----

Hi Andrew,

On Fri, Jan 06, 2012 at 10:58:06AM -0500, Andrew Jones wrote:

quoted

----- Original Message -----

quoted

On Fri, Jan 06, 2012 at 10:43:09AM +0100, Andrew Jones wrote:

quoted

PV-on-HVM guests may want to use the xen keyboard/mouse
frontend,
but
they don't use the xen frame buffer frontend. For this case it
doesn't
make much sense for INPUT_XEN_KBDDEV_FRONTEND to depend on
XEN_FBDEV_FRONTEND. The opposite direction always makes more
sense,
i.e.
if you're using xenfb, then you'll want xenkbd. Switch the
dependencies.

You need to CC as well these people that have 'maintainer' field
on
them:

konrad@phenom:~/work/linux$ scripts/get_maintainer.pl -f
drivers/video/Kconfig
Florian Tobias Schandinat [off-list ref]
(maintainer:FRAMEBUFFER LAYER)
linux-fbdev@vger.kernel.org (open list:FRAMEBUFFER LAYER)
linux-kernel@vger.kernel.org (open list)
konrad@phenom:~/work/linux$ scripts/get_maintainer.pl -f
drivers/input/misc/Kconfig
Dmitry Torokhov [off-list ref] (maintainer:INPUT
(KEYBOARD,...,commit_signer:9/16=56%)
Samuel Ortiz [off-list ref] (commit_signer:3/16=19%)
Anirudh Ghayal [off-list ref] (commit_signer:2/16=12%)
Peter Ujfalusi [off-list ref] (commit_signer:2/16=12%)
Alan Cox [off-list ref] (commit_signer:2/16=12%)
linux-input@vger.kernel.org (open list:INPUT (KEYBOARD,...)
linux-kernel@vger.kernel.org (open list)

Thanks. Replied with them in CC.

Drew

quoted

quoted

Signed-off-by: Andrew Jones <redacted>
---
 drivers/input/misc/Kconfig |    2 +-
 drivers/video/Kconfig      |    1 +
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/input/misc/Kconfig

b/drivers/input/misc/Kconfig
index 22d875f..36c15bf 100644

--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig

@@ -533,7 +533,7 @@ config INPUT_CMA3000_I2C
 
 config INPUT_XEN_KBDDEV_FRONTEND
 	tristate "Xen virtual keyboard and mouse support"
-	depends on XEN_FBDEV_FRONTEND
+	depends on XEN

This is OK with me.

quoted

quoted

quoted

 	default y
 	select XEN_XENBUS_FRONTEND
 	help

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index d83e967..269b299 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig

@@ -2269,6 +2269,7 @@ config XEN_FBDEV_FRONTEND
 	select FB_SYS_IMAGEBLIT
 	select FB_SYS_FOPS
 	select FB_DEFERRED_IO
+	select INPUT_XEN_KBDDEV_FRONTEND

But here you need to either depend on or select INPUT as select does
not
resolve dependencies for selected symbol.

Would I actually need 'select INPUT' and select 'INPUT_MISC'? Maybe
'depends on' would just be cleaner and safer. I'll send a V2.

Thanks,
Drew

Thanks.

--
Dmitry

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel