RE: [PATCH 1/1] Staging: hv: util: Invoke cn_netlink_send() in a work context
From: KY Srinivasan <kys@microsoft.com>
Date: 2011-10-10 14:10:16
Also in:
lkml
-----Original Message----- From: Christoph Hellwig [mailto:hch@infradead.org] Sent: Monday, October 10, 2011 7:44 AM To: KY Srinivasan Cc: gregkh@suse.de; linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; virtualization@lists.osdl.org; ohering@suse.com; Haiyang Zhang Subject: Re: [PATCH 1/1] Staging: hv: util: Invoke cn_netlink_send() in a work context On Sun, Oct 09, 2011 at 07:42:28PM -0700, K. Y. Srinivasan wrote:quoted
Invoke cn_netlink_send() in a work context as opposed being called in the context of channel callback. On entry into the channel callback code the channel inbound spin lock is held and deferring to a work context avoids having to invoke cn_netlink_send() while holding the inbound lock. As part of this adjustment, also increase the timeout value for waiting for the user level component of KVP.As told a few times you really need to move away from the connector before sumitting the KVP support. What about tackling that instead of band aiding it?
Christoph, I am still not sure what the issues with the connector are that you mention. When I was initially designing the KVP feature, we did have a discussion of what the kernel/ user-mode transport should be and the connector interface was the consensus then. The changes in this patch, I would probably make no matter what the transport mechanism was; nothing connector specific. Regards, K. Y