Re: [PATCH] Staging: hv: storvsc: Show the modulename in /sys/class/scsi_host/*/proc_name

On Fri, Sep 09, 2011 at 10:45:23AM +0200, Olaf Hering wrote:

On Thu, Sep 08, Greg KH wrote:

quoted

On Thu, Sep 08, 2011 at 06:26:50PM +0200, Olaf Hering wrote:

quoted

quoted

+++ b/drivers/staging/hv/storvsc_drv.c

@@ -1333,7 +1333,8 @@ static DEF_SCSI_QCMD(storvsc_queuecomman
 /* Scsi driver */
 static struct scsi_host_template scsi_driver = {
 	.module	=		THIS_MODULE,
-	.name =			"storvsc_host_t",
+	.name =			"hv_storvsc",
+	.proc_name =		"hv_storvsc",

Shouldn't this be MODULE_NAME so it handles any potential name change in
the future and makes it a bit more obvious as to what is going on here?

MODULE_NAME is just another define and appearently not used to assemble
a kernel module. Is DRV_NAME depreciated?

Sorry, I should have said KBUILD_MODNAME, that will give you what you
want here.

greg k-h