On Tue, Aug 30, 2011 at 01:29:49PM +0300, Dan Carpenter wrote:

quoted

err3:
	free_irq(irq, hv_acpi_dev);
err2:
	bus_unregister(&hv_bus);
err1:
	hv_cleanup();

Also here is an oldbie trick.  You could use multiples of ten like
err30, err20, and err10.  That way if you can add more error handling
in the middle without changing the numbering.  I knew my GW-BASIC
experience would come in handy one day.  :)

The better way to label things is based on what happens when you get
there: err_irq, err_unregister, err_cleanup.

Yes, that's the best way to do this, thanks for pointing it out.

greg k-h