Thread (70 messages) flat view 70 messages, 4 authors, 2011-07-05
STALE5557d

[PATCH 40/40] Staging: hv: storvsc: No need to copy from bounce buffer in case of failure

From: "K. Y. Srinivasan" <kys@microsoft.com>
Date: 2011-06-29 14:25:52
Also in: lkml
Subsystem: staging subsystem, the rest · Maintainers: Greg Kroah-Hartman, Linus Torvalds

In case we are not able to submit an I/O, there is no need to copy
from the bounce buffers; get of the code to copy.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Abhishek Kane <redacted>
Signed-off-by: Hank Janssen <redacted>
---
 drivers/staging/hv/storvsc_drv.c |   10 +---------
 1 files changed, 1 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/hv/storvsc_drv.c b/drivers/staging/hv/storvsc_drv.c
index cc4b128..e2cdd7b 100644
--- a/drivers/staging/hv/storvsc_drv.c
+++ b/drivers/staging/hv/storvsc_drv.c
@@ -1421,17 +1421,9 @@ retry_request:
 	if (ret == -EAGAIN) {
 		/* no more space */
 
-		if (cmd_request->bounce_sgl_count) {
-			/*
-			 * FIXME: We can optimize on writes by just skipping
-			 * this
-			 */
-			copy_from_bounce_buffer(scsi_sglist(scmnd),
-						cmd_request->bounce_sgl,
-						scsi_sg_count(scmnd));
+		if (cmd_request->bounce_sgl_count)
 			destroy_bounce_buffer(cmd_request->bounce_sgl,
 					      cmd_request->bounce_sgl_count);
-		}
 
 		kmem_cache_free(host_dev->request_pool, cmd_request);
 
-- 
1.7.4.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help