RE: [PATCH 12/49] Staging: hv: storvsc: Add a DMI signature to support auto-loading

-----Original Message-----
From: Greg KH [mailto:greg@kroah.com]
Sent: Tuesday, June 07, 2011 2:58 PM
To: KY Srinivasan
Cc: Christoph Hellwig; gregkh@suse.de; linux-kernel@vger.kernel.org;
devel@linuxdriverproject.org; virtualization@lists.osdl.org; Haiyang Zhang;
Abhishek Kane (Mindtree Consulting PVT LTD)
Subject: Re: [PATCH 12/49] Staging: hv: storvsc: Add a DMI signature to support
auto-loading

On Tue, Jun 07, 2011 at 02:54:25PM +0000, KY Srinivasan wrote:

quoted

quoted

-----Original Message-----
From: Christoph Hellwig [mailto:hch@infradead.org]
Sent: Monday, June 06, 2011 7:13 PM
To: KY Srinivasan
Cc: gregkh@suse.de; linux-kernel@vger.kernel.org;
devel@linuxdriverproject.org; virtualization@lists.osdl.org; Haiyang Zhang;
Abhishek Kane (Mindtree Consulting PVT LTD)
Subject: Re: [PATCH 12/49] Staging: hv: storvsc: Add a DMI signature to

support

quoted

quoted

auto-loading

On Mon, Jun 06, 2011 at 03:49:36PM -0700, K. Y. Srinivasan wrote:

quoted

To support auto-loading the storvsc driver, add a DMI signature.

The storvsc driver is not a DMI driver, but a vmbus driver.  As such it
should have a vmbus table that is used for autoloading, not a dmi one.

A while ago, Greg introduced DMI signatures to these drivers to support
auto-loading. This signature is not used for anything else. For some reason,
this storvsc driver was missing this signature. I added it again to only support
auto-loading.

Yes, that was there to solve the original problem of autoloading the
driver.

But Christoph is correct here, the vmbus needs a way to autoload its own
drivers based on the GUID signatures of the devices it finds on the
hyperv bus.  So the correct thing to do in the long-run is to implement
this (which is one of the things the bus needs to do before it can move
out of staging).

I'll take this patch as-is for now though, as it does solve the
immediate issue.

Thanks Greg. Can you give me some pointers here as to what needs to be
done here. Looking at the code for virtio, it looks like I would need to add stuff
to scripts/mod/file2alias.c as well as to include/linux/mod_devicetable.h. Will you
accept patches for these files to support an ID space for Hyper-V vmbus drivers.

Regards,

K. Y