Re: [PATCH 1/1] [virt] virtio-blk: Use ida to allocate disk index
From: Mark Wu <hidden>
Date: 2011-06-01 08:25:48
On 06/01/2011 03:24 AM, Mark Wu wrote:
- if (index_to_minor(index)>= 1<< MINORBITS)
- return -ENOSPC;
+ do {
+ if (!ida_pre_get(&vd_index_ida, GFP_KERNEL))
+ return err;
+There's a problem in above code: err is not initialized before using, so
change it to return -1;
+ do {
+ if (!ida_pre_get(&vd_index_ida, GFP_KERNEL))
+ return -1;