RE: [PATCH 00/25] Staging: hv: Cleanup vmbus driver code
From: KY Srinivasan <kys@microsoft.com>
Date: 2011-05-01 15:46:27
Also in:
lkml
-----Original Message----- From: Christoph Hellwig [mailto:hch@infradead.org] Sent: Sunday, May 01, 2011 11:41 AM To: Greg KH Cc: KY Srinivasan; Christoph Hellwig; gregkh@suse.de; linux- kernel@vger.kernel.org; devel@linuxdriverproject.org; virtualization@lists.osdl.org Subject: Re: [PATCH 00/25] Staging: hv: Cleanup vmbus driver code On Fri, Apr 29, 2011 at 09:40:25AM -0700, Greg KH wrote:quoted
Are you sure the libata core can't see this ide controller and connect to it? That way you would use the scsi system if you do that and you would need a much smaller ide driver, perhaps being able to merge it with your scsi driver. We really don't want to write new IDE drivers anymore that don't use libata.The blkvsc driver isn't an IDE driver, although it currently claims the old IDE drivers major numbers, which is a no-no and can't work in most usual setups.
What is the issue here? This is no different than what is done in other Virtualization platforms. For instance, the Xen blkfront driver is no different - if you specify the block device to be presented to the guest as an ide device, it will register for the appropriate ide major number. Regards, K. Y
I'm pretty sure I already complained about this in a previous review round.