Re: [PATCH 10/21] Staging: hv: Cleanup root device handling
From: Greg KH <hidden>
Date: 2011-03-14 19:38:58
Also in:
lkml
On Thu, Mar 10, 2011 at 02:08:06PM -0800, K. Y. Srinivasan wrote:
Now we can complete the cleanup of the root device management. Use the preferred APIs for creating and managing the root device. As part of this cleanup get rid of the root device object from vmbus_driver_context.
I don't understand, what is the "root device"? The hyper-v "bus controller"?
quoted hunk ↗ jump to hunk
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com> Signed-off-by: Mike Sterling <redacted> Signed-off-by: Abhishek Kane <redacted> Signed-off-by: Hank Janssen <redacted> --- drivers/staging/hv/vmbus_drv.c | 126 ++++++---------------------------------- 1 files changed, 18 insertions(+), 108 deletions(-)diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c index b473f46..8b9394a 100644 --- a/drivers/staging/hv/vmbus_drv.c +++ b/drivers/staging/hv/vmbus_drv.c@@ -19,6 +19,7 @@ * Hank Janssen <hjanssen@microsoft.com> */ #include <linux/init.h> +#include <linux/err.h> #include <linux/module.h> #include <linux/device.h> #include <linux/irq.h>@@ -40,6 +41,8 @@ #define VMBUS_IRQ 0x5 #define VMBUS_IRQ_VECTOR IRQ5_VECTOR +static struct device *root_dev; /* Root device */
This shouldn't be a "raw" struct device, should it? It should be of a type that shows exactly what it is. Is it a hyper_v device that talks on the bus? Or is it a "platform" device that controls all of the devices on the bus, and as such should be the "root" device of the bus tree? confused, greg k-h