RE: [PATCH 1/4] staging: hv: Fix the code depending on struct vmbus_driver_context data order
From: Haiyang Zhang <haiyangz@microsoft.com>
Date: 2011-02-23 22:48:31
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2011-02-23 · [PATCH 1/4] staging: hv: Fix the code depending on struct vmbus_driver_context data order · Haiyang Zhang <haiyangz@microsoft.com>
From: Greg KH [mailto:greg@kroah.com] Sent: Wednesday, February 23, 2011 4:27 PMquoted
struct driver_context { struct hv_guid class_id; - struct device_driver driver; + struct hv_driver *hv_drv;If you have a pointer to hv_driver, why do you need a full 'struct device_driver' here? That sounds really wrong. Actually, having 'struct device_driver' within a structure called "driver_context" seems wrong, this should be what 'struct hv_driver' really is, right?
The hv_driver contains Hyper-V specific data, like hv_guid. But the struct driver_context contains data and functions related to Linux kernel side, such as the struct device_driver defined by kernel. So, they are kept separately. (just saw Ky's email, which further explained the layering.) Thanks, - Haiyang