Re: [PATCH 02/14] virtio: console: Remove control vq data only if using multiport support

On (Mon) Sep 06 2010 [17:59:39], Rusty Russell wrote:

On Thu, 2 Sep 2010 10:11:41 pm Amit Shah wrote:

quoted

If a portdev isn't using multiport support, it won't have any control vq
data to remove.

Signed-off-by: Amit Shah <redacted>

So previously it would crash if it was ever removed?  If so, it'd be
nice to see that in the patch description :)

Well, yeah.  If any module remove or port / device remove was performed
earlier, there would be crashes in multiple places (as noted in the
0/14) message.  I didn't want to scare away people by repeating it for
each patch ;-)

You're right, though, I should've mentioned it.  The 0/N message gets
lost and the commit history won't reflect that info.

Thanks for picking them up!

		Amit