Thread (10 messages) 10 messages, 2 authors, 2010-02-12

Re: [PATCH 1/6] virtio: Initialize vq->data entries to NULL

From: Rusty Russell <hidden>
Date: 2010-02-12 09:58:55

On Fri, 12 Feb 2010 03:32:14 pm Amit Shah wrote:
vq operations depend on vq->data[i] being NULL to figure out if the vq
entry is in use.

We have to initialize them to NULL to ensure we don't work with junk
data and trigger false BUG_ONs.
Not really.  We wouldn't detect some bogus get_buf() calls if it's not NULL,
but we only *need* this since detach_bufs was added.

I've updated the commit message to reflect it.

Thanks,
Rusty.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help