Re: [PATCH 2/4] virtio_net: return NETDEV_TX_BUSY instead of queueing an extra skb.
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2009-06-02 23:45:32
On Tue, Jun 02, 2009 at 11:25:57PM +0930, Rusty Russell wrote:
Or, we could just "return NETDEV_TX_BUSY;". I like that :)
No you should fix it so that you check the queue status after transmitting a packet so we never get into this state in the first place. NETDEV_TX_BUSY is just passing the problem to someone else, which is not nice at all. For example, anyone running tcpdump will now see the packet twice. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt