Re: [RFC 1/3] hvc_console: rework setup to replace irq functions with callbacks
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2008-10-13 08:44:17
Also in:
linuxppc-dev, lkml
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2008-10-13 08:44:17
Also in:
linuxppc-dev, lkml
if (--hp->count == 0) {
- if (hp->ops->notifier_del)
- hp->ops->notifier_del(hp, hp->data);
-
/* We are done with the tty pointer now. */
hp->tty = NULL;
spin_unlock_irqrestore(&hp->lock, flags);
+ if (hp->ops->notifier_del)
+ hp->ops->notifier_del(hp, hp->data);
+I will try. Of course the risk here is that the interrupt happens after we set hp->tty to NULL, so we probably need to check within the interrupt handler for a NULL tty. I haven't checked if that's the case (I'm not in front of the code right now). Ben.