Re: [PATCH 4/7] Moved the io struct up to the generic lg.h

--
On Thu, 9 Aug 2007, Jes Sorensen wrote:

Stephen Rothwell wrote:

quoted

On Wed, 08 Aug 2007 20:32:15 -0400 Steven Rostedt [off-list ref]
wrote:

quoted

diff --git a/drivers/lguest/i386/lg.h b/drivers/lguest/i386/lg.h
index 64f0abe..c5ea14c 100644
--- a/drivers/lguest/i386/lg.h
+++ b/drivers/lguest/i386/lg.h

@@ -20,6 +20,8 @@
 #include <linux/err.h>
 #include <asm/semaphore.h>
 #include "irq_vectors.h"
+/* some files include this, some include the parent */
+#include "../lg.h"

Surely everything should just include the parent which allows for easier
consolidation over time. (as you are doing here)

Whats wrong with introducing an include/asm-<arch>/lg.h and have the
parent do #include <asm/lg.h> ? Seems much cleaner to me.

Seems cleaner to me to!  I think I'll do that.

Oh, wait! I did.  ;-)

-- Steve

P.S. Sorry, couldn't resist.