On Fri, 2007-08-17 at 10:22 +0200, Christian Borntraeger wrote:

Hello Rusty,

while playing with your virtio descriptor code, I realized that the desc_pages 
data structure is not 64 bit safe. struct lguest_desc desc[NUM_DESCS] can be 
smaller than a page, as struct lguest_desc is 24 bytes on 64bit systems. Lets 
add a char padding to make the next page really page aligned.

Indeed.  This is something which would need fixing for a non-32 bit
platform.

Btw. the new_io_desc.patch does not apply on current git. What base should I 
use?

Unfortunately, the lguest tree is undergoing a significant reshuffle as
files get moved (non-i386 support).  The lguest patch queue as a whole
should apply tho.

Thanks!
Rusty.