Re: [PATCH 4/7] Moved the io struct up to the generic lg.h

--
On Thu, 9 Aug 2007, Stephen Rothwell wrote:

On Wed, 08 Aug 2007 20:32:15 -0400 Steven Rostedt [off-list ref]
wrote:

quoted

diff --git a/drivers/lguest/i386/lg.h b/drivers/lguest/i386/lg.h
index 64f0abe..c5ea14c 100644
--- a/drivers/lguest/i386/lg.h
+++ b/drivers/lguest/i386/lg.h

@@ -20,6 +20,8 @@
 #include <linux/err.h>
 #include <asm/semaphore.h>
 #include "irq_vectors.h"
+/* some files include this, some include the parent */
+#include "../lg.h"

Surely everything should just include the parent which allows for easier
consolidation over time. (as you are doing here)

Yeah, that sounds better. This was my attempt at not modifing the
i386/ stuff too much.  But I can have those files change to do a "../lg.h"
include.  Again, doing the move plus change to keep things building. Hmm,
I guess git can handle that.

quoted

--- a/drivers/lguest/lg.h
+++ b/drivers/lguest/lg.h

@@ -1,3 +1,19 @@
+#ifndef _LGUEST_LG_GENERIC
+#define _LGUEST_LG_GENERIC

Maybe _LGUEST_LG_H?  and the arch ones could use _LGUEST_I386_LG_H etc.

Noted. Will do in the next release.

Thanks,

-- Steve