Re: [PATCH 25/25] [PATCH] add paravirtualization support for x86_64

On Thursday 09 August 2007 01:18:57 Rusty Russell wrote:

On Wed, 2007-08-08 at 11:49 -0300, Glauber de Oliveira Costa wrote:

quoted

On 8/8/07, Andi Kleen [off-list ref] wrote:

quoted

quoted

+EXPORT_SYMBOL(paravirt_ops);

Definitely _GPL at least.

Sure.

We ended up making it EXPORT_SYMBOL in i386 because every driver wants
to save and restore interrupt state.

Ah true.
 

But questionably-licensed drivers might be less of a concern on x86-64.

Nvidia/ATI and other binary modules exist too and users will probably unhappy 
if they cannot run them anymore.

But at usually irq state changes should be patched in anyways and won't
need paravirt I guess? 

Hmm, actually thinking about it the module loader probably has no clue
that the relocation it linked will be overwritten so it'll check
for the export anyways.

So the alternatives would be to add ugly hacks to the module loader
or split paravirt_ops in "common" and "low level system" areas or 
export it as a normal export.

Not sure what's best. Ok using a normal export is easiest and not
that big an issue.

-Andi