Re: [PATCH 18/25] [PATCH] turn priviled operations into macros in entry.S

On Wednesday 08 August 2007 15:58:06 Glauber de Oliveira Costa wrote:

On 8/8/07, Andi Kleen [off-list ref] wrote:

quoted

quoted

+#define SYSRETQ                                              \
+                     movq    %gs:pda_oldrsp,%rsp;    \
+                     swapgs;                         \
+                     sysretq;

When the macro does more than sysret it should have a different
name

That's fair. Again, suggestions are welcome. Maybe SYSCALL_RETURN ?

Sounds reasonable.

quoted

quoted

 retint_restore_args:
-     cli
+     DISABLE_INTERRUPTS(CLBR_ANY)

Similar.

I don't think so. They are live here, but restore_args follows, so we
can safely clobber anything here. Right?

The non argument registers cannot be clobbered.



-Andi