Re: [PATCH 3/25] [PATCH] irq_flags / halt routines

On 8/8/07, Andi Kleen [off-list ref] wrote:

quoted

+#ifdef CONFIG_PARAVIRT
+#include <asm/paravirt.h>
+#  ifdef CONFIG_X86_VSMP
+static inline int raw_irqs_disabled_flags(unsigned long flags)
+{
+     return !(flags & X86_EFLAGS_IF) || (flags & X86_EFLAGS_AC);
+}
+#  else
+static inline int raw_irqs_disabled_flags(unsigned long flags)
+{
+     return !(flags & X86_EFLAGS_IF);
+}
+#  endif

You should really turn the vsmp special case into a paravirt client first
instead of complicating all this even more.

By "client" you mean a user of the paravirt interface?

quoted

+#ifndef CONFIG_PARAVIRT
+#define raw_safe_halt        native_raw_safe_halt
+#define halt         native_halt
+#endif /* ! CONFIG_PARAVIRT */

This seems inconsistent

Sorry andi. Can't see why. Could you elaborate?


-- 
Glauber de Oliveira Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."